[Libvir] [PATCH] Remote 0/8: Plan

Richard W.M. Jones rjones at redhat.com
Mon May 14 08:45:58 UTC 2007


Daniel P. Berrange wrote:
> On Wed, May 02, 2007 at 07:04:44PM +0100, Richard W.M. Jones wrote:
>> Below is the plan for delivering the remote patch for review in stages. 
>>  More details about in each email.  I only expect to get through the 
>> first two emails today.
> 
> I've been testing this out for real today
> 
>  - IPv6 works correctly
>  - Once I generated the client & server certs the TLS stuff was working
>    pretty much without issue. Though we could do with printing out some
>    clearer stuff in the scenario where user typos on cert/key path names
>    as the current stuff is a littel obscure.

Yes, I've fixed this in the latest version so it prints out meaningful & 
helpful errors.

>  - I've been testing with the QEMU driver and hit a few problems with
>    the fact that qemuinternal.c will grab the URIs containing hostnames
>    in the virConnectOpen call. So qemu was getting the connection before
>    remote driver had a chance. Should be simply to path qemu_internal
>    to ignore URIs with a hostname set.

I don't know why this is necessary, since the remote driver is always 
supposed to be called first.  But anyway I added:

      if (!uri->scheme ||
          strcmp(uri->scheme, "qemu") ||
+        uri->server || /* remote driver should handle these */
          !uri->path) {
          xmlFreeURI(uri);
          return VIR_DRV_OPEN_DECLINED;
      }

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070514/de3a980c/attachment-0001.bin>


More information about the libvir-list mailing list