[Libvir] [PATCH] Device attach/detach on virsh(XML version)

Richard W.M. Jones rjones at redhat.com
Wed May 23 08:46:34 UTC 2007

Mark McLoughlin wrote:
> On Tue, 2007-05-22 at 15:16 +0100, Richard W.M. Jones wrote:
>> Richard W.M. Jones wrote:
>>> +    buffer = realloc (buffer, len+1);
>>> +    if (buffer == NULL) goto out_of_memory;
> 	Note, if realloc() fails, the original buffer isn't freed. So, you want
> to make sure you free the original one.

I even kept the oldbuffer around for this reason, but then forgot to 
free it!

Grrrr ... garbage.collection++


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070523/17f21b7a/attachment-0001.bin>

More information about the libvir-list mailing list