[Libvir] [PATCH] Don't throw away errors in virConnectOpen (at least not so often)

Richard W.M. Jones rjones at redhat.com
Tue May 1 14:04:32 UTC 2007

Error messages, I like them.  I don't like them to be thrown away.

A nice feature of virterror is that it'll throw away errors under the 
following conditions:
(1) You are in virConnectOpen, and
(2) You pass a non-NULL virConnectPtr to __virRaiseError.

libvirt has a lot of errors which meet those conditions - the attached 
patch fixes the ones I could find.

It also fixes qemuOpenConnection so that it doesn't try to open a Unix 
socket with random stack data.

It also adds error messages in some useful places where previously there 
was an error, but no message.


Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421

Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.
Registered in England and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Charlie Peters (USA) and David
Owens (Ireland)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-open-errors-20070501.patch
Type: text/x-patch
Size: 10451 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070501/010d000a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070501/010d000a/attachment-0003.bin>

More information about the libvir-list mailing list