[Libvir] [PATCH] Device attach/detach on virsh (command option version)

Masayuki Sunou fj1826dm at aa.jp.fujitsu.com
Tue May 29 06:41:56 UTC 2007


This patch adds virsh attach-device/detach-device.
This supports a definition of a device by command option(proposal 1).

I examine the following opinions, and "attach-interface" supports only two
common case (bridge, virtual network). 

> Networking is more complicated because there are 8 (!) different ways to
> connected up VMs so far. We could either have huge numbers of args, or
> we could just support the two common cases (bridge, virtual network) and
> say for more complex cases use full XML.

Any comments are welcome!

Signed-off-by: Masayuki Sunou <fj1826dm at aa.jp.fujitsu.com>

Masayuki Sunou.

In message <200705111842.IJH95853.739E2KNG at aa.jp.fujitsu.com>
   "Re: [Libvir] [RFC] Device attach/detach on virsh"
   "Masayuki Sunou <fj1826dm at aa.jp.fujitsu.com>" wrote:

> Hi
> I understood as follows.
> * There is no problem in a proposal 1 and a proposal 2
> * It is better that the user can choose use of XML and use of command-option
>   by the situation
> Therefore, I want to add both proposal 1 and proposal 2 to virsh.
> There is no problem in this opinion?
> And, I am going to correct about naming.
>  vif --> interface
>  vbd --> disk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: attach_detach_opt.patch
Type: application/octet-stream
Size: 18206 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070529/5283166d/attachment-0001.obj>

More information about the libvir-list mailing list