[Libvir] [PATCH] add scheduler API(take 3?)

Richard W.M. Jones rjones at redhat.com
Wed May 30 15:40:39 UTC 2007


The attached patch fixes some things in your add_scheduler10.patch (you 
need to apply this patch on top of your patch):

* Lots of error checking added.  If the lowest level function detects an 
error, it *must* report a useful message.

* Make libvirt.h match libvirt.h.in.  If you edit just libvirt.h then 
any changes you make will be lost next time someone runs ./configure.

* Removed VIR_DOMAIN_SCHED_FIELD_INIT.  This field is now initialised 
with zero.

* Changed the type of that field to the more logical 
virSchedParameterType type.

* virDomainSetSchedulerParameters, nparams does not really need to be a 
pointer (can it ever be changed?)

* In virsh, only call virDomainSetSchedulerParameters if the user has 
requested a parameter to change.

* In virDomainGetSchedulerType, allow nparams (pointer) to be NULL - eg. 
in case the caller doesn't care about the number of parameters.

Note: My Xen machine is completely broken at the moment so I haven't 
been able to test this, just compile it.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_scheduler10-rich.patch
Type: text/x-patch
Size: 16847 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070530/19bc774c/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070530/19bc774c/attachment-0003.bin>

More information about the libvir-list mailing list