[Libvir] [PATCH] Handle failed strdup and malloc.

Richard W.M. Jones rjones at redhat.com
Wed Nov 14 15:35:41 UTC 2007

Jim Meyering wrote:
> I noticed a bunch of unchecked strdup's in a row,
> and audited the rest of the file:
> 	Handle failed strdup and malloc.
> 	* src/remote_internal.c: Don't dereference NULL after
> 	failed strdup or malloc in doRemoteOpen.

This is all good stuff, except that the calls to error () should take 
the conn (virConnectPtr) as first argument if conn is available, which 
it is here.  So +1 if that change is made.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20071114/f986859d/attachment-0001.bin>

More information about the libvir-list mailing list