[Libvir] [PATCH] virterror Cleanups

Richard W.M. Jones rjones at redhat.com
Tue Nov 20 10:36:21 UTC 2007


Daniel Veillard wrote:
> On Tue, Nov 20, 2007 at 03:02:09PM +0900, Saori Fukuta wrote:
>> Hi,
>>
>> The virsh command sometimes says wrong message that indicating where 
>> the error is coming from. So I have some fixes for libvirt error.
>> * Add two number for virErrorDomain (virterror.h)
>> * Add six message indicating where it's coming from (virterror.c)
>> * Fix virErrorDomain number specified with __virRaiseError
>>   (openvz_conf.c/openvz_driver.c/stats_linux.c/xm_internal.c)
> 
>   Thanks a lot for chasing and fixing those issues, this makes a lot
> of sense, applied and commited to CVS !

Agreed +1, but I think that VIR_FROM_LINUX should be renamed to 
VIR_FROM_STATS_LINUX.

Should I make this change?

Rich.

/me really must change the ocaml bindings to autogenerate these lists of 
errors, otherwise the bindings crash when an unknown error is generated :-(

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20071120/834da6f5/attachment-0001.bin>


More information about the libvir-list mailing list