[Libvir] [PATCH] BZ#251641: Allow to change the cpu pinning for inactive domain

Richard W.M. Jones rjones at redhat.com
Tue Nov 27 14:55:22 UTC 2007

Daniel Veillard wrote:
> On Tue, Nov 27, 2007 at 01:19:48PM +0000, Richard W.M. Jones wrote:
>> Morning Saori,
>> You need to call the error function for each error condition, eg:
>> if (mapstr == NULL) {
>>   xenXMError (domain ? domain->conn : NULL, VIR_ERR_NO_MEMORY, 
>> __FUNCTION__);
>>   return -1;
>> }
>> (Much of the current libvirt code gets this wrong, and it's a great deal 
>> of pain caused by virterror, but there's no sensible way to change 
>> things from here.)
>> The inner loop is still quadratic even with snprintf because you're 
>> copying the string each time.  I've changed it below to use a virBuffer 
>> instead.
>> If you ./configure --enable-compile-warnings=error then any warnings 
>> will turn into errors.  There was one warning in the patch you sent.
>> Modified version of the patch is attached.  **NOTE** I've only compiled 
>> it, because I don't have any suitable machine to test it on.
>   That patch looks good to me.


If you can check that the patch works for you, then we can commit it.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20071127/caca5e3b/attachment-0001.bin>

More information about the libvir-list mailing list