[Libvir] PATCH: Implement CDROM media change for QEMU/KVM driver
Jim Paris
jim at jtan.com
Mon Oct 15 15:19:36 UTC 2007
Richard W.M. Jones wrote:
> Richard W.M. Jones wrote:
> >+ strcat(cmd, newdisk->src);
>
> Also, is quoting/escaping required? In a naive libvirt-based app, it's
> plausible that the string is provided by the user and could contain \n
> to send arbitrary commands to the qemu console.
Agreed. We can use something like qemudEscapeShellArg for that.
This (untested) patch adds qemudEscapeArg for non-shell arguments.
-jim
More information about the libvir-list
mailing list