[Libvir] [for discussion only] virDomainBlockPeek preliminary implementation (version 2)
Richard W.M. Jones
rjones at redhat.com
Tue Oct 16 18:41:24 UTC 2007
Jim Meyering's been sending me private emails all afternoon about this
and that wrong in this patch, so here's an update :-)
It fixes:
- unnecessary initialisations removed
- changed the dumb for(;;) putchar into an fwrite call
- cure multiple memory leaks in virsh
- fixed const-correctness of the callback function
- use a wrapper around strtoll
- replaced some !strcmp with STREQ (etc)
- use AC_SYS_LARGEFILE to get portable support for 64-bit file offsets
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-peek-2.patch
Type: text/x-patch
Size: 37289 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20071016/68ea040e/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20071016/68ea040e/attachment-0003.bin>
More information about the libvir-list
mailing list