[Libvir] [PATCH] finish NUMA code reorg, plug cpuset at creat time support
veillard at redhat.com
Tue Oct 23 09:29:21 UTC 2007
On Tue, Oct 23, 2007 at 04:07:34PM +0900, Saori Fukuta wrote:
> On Mon, 22 Oct 2007 12:39:50 -0400 Daniel Veillard wrote:
> > The following patch finishes the cleanup for NUMA parsing code:
> > - the cpuset parsing is moved to xml.c
> > - some comments and cleanups of the include
> > then add the output of a (cpus '...') line based on the /domain/vcpu/@cpuset
> > attributes, this is parsed and reserialized as ranges to avoid any possibility
> > of misinterpretation of say ^ or any special syntax we may want to add in
> > the future.
> > A few things to note:
> > - dependant on the tiny patch I sent earlier today
> > - if we notice that the set covers all CPU maybe we should
> > avoid outputing (cpus '...'), trivial to add
> > - mostly untested yet
> It seems work fine for creating a guest, i.e. I can set the cpuset by
> "virsh create" with XML file containing a cpuset parameter.
> This fix will solve "create" of the following BZ.
> - BZ#223833:
> FEAT RHEL5.2: About the setting of CPU affinity at virsh create/reboot
> I think we also need to fix for "start/define/dumpxml".
> So, I attached the patch for them. Could you check it ?
Okay, I looked at it, the only worry I have is that it takes the
cpus values as emitted in the S-Expr and output it directly in the XML.
I guess it really depends how xend exports this information, reading
the code it seems they only generate a comma separated CPU list on output
(in which case reusing libvirt parsing/serialization to compact it to
ranges would be nicer), but I don't have machines with enough CPUs to
really see this, could you have a lookm before I check this in ?
> Anyway, I will have some more test for the cpuset.
okay, thanks !
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard at redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
More information about the libvir-list