[Libvir] PATCH: Prevent zombie ssh tunnels
Richard W.M. Jones
rjones at redhat.com
Tue Sep 11 08:27:52 UTC 2007
Daniel P. Berrange wrote:
> I noticed that when using the SSH tunnel for the remote driver I ended up
> with alot of zombie SSH processes. We simply forgot to waitpid() on the
> child when a connection attempt failed, or when shutting down an open remote
> connection. Attached is a possible patch
This is a good catch.
I would prefer to factor out that common wait/kill code into a separate
function, particularly because it seems to kill the ssh client after 3
seconds of waiting, so it'd be good to document that.
But apart from that, +1.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070911/a9586d72/attachment-0001.bin>
More information about the libvir-list
mailing list