[Libvir] Re: [PATCH] add no_tty flag for ssh

[Richard W.M. Jones]

Daniel P. Berrange wrote:
> On Thu, Sep 20, 2007 at 01:10:28PM +0100, Richard W.M. Jones wrote:
>> Daniel P. Berrange wrote:
>>> The use of '-o PasswordAuthentication=no' isn't sufficient because even
>>> with pulic key / gssapi auth schemes it may prompt for passwords and/or
>>> passphrases.
>>>
>>> I think we need to use  '-T -o BatchMode=yes', and regardless of the
>>> no_tty flag I think it could be wise to add '-e none'.
>> Yes, that's right.  Try this patch.
> 
> There's something not quite right going on. It correctly prevents the
> prompting of passwords, but the '?' seems to be passed through to the
> remote end. So the server side tries to open 'qemu:///system?' and
> fails.
> 
> Now technically '?' is a valid URI character and so qemu_driver.c should
> handle it, by parsing the URI properly, rather than STREQ(qemu:///system),
> but I think the client side should avoid appending the '?' too if there is
> no parameter to pass across.

The URI is reconstructed using xmlSaveUri from libxml2, and as far as I 
can see that always appends a '?' character.

The logic of remote_internal.c has got rather convoluted since qemu 
support was added so I can't see why this doesn't hit us in the current 
code, but it certainly hits us now.  Only way I can see around this is 
to write proper URI parsing into qemu_driver.c ...

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070920/4f6951e6/attachment-0001.bin>