[Libvir] [PATCH] Have xenDaemonDetachDevice() remove device configuration

[Daniel Veillard]

On Tue, Apr 08, 2008 at 01:06:12PM -0700, Ryan Scott wrote:
> 
> When a user runs 'virsh detach-disk' on a running domain, the disk is 
> removed, but reappears after the domain is rebooted.  This seems odd, as 
> someone who types detach-disk most likely wants the change to be permanent.
> 
> This patch updates the code in xenDaemonDetachDevice() to pass the 
> rm_cfg flag to Xen, so that the change is committed to the domain's 
> configuration file.
> 
> This change depends on a xen patch that was committed to unstable on 
> March 20: 
> http://lists.xensource.com/archives/html/xen-changelog/2008-03/msg00122.html

  but what happens if the flag is passed down while the xend version doesn't
support it ? if this breaks we need to check first that the remote support
it (based on a version change at some point), isn't it ?

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/