[Libvir] [PATCH] Have xenDaemonDetachDevice() remove device configuration

[Richard W.M. Jones]

On Tue, Apr 08, 2008 at 01:06:12PM -0700, Ryan Scott wrote:
> When a user runs 'virsh detach-disk' on a running domain, the disk is 
> removed, but reappears after the domain is rebooted.  This seems odd, as 
> someone who types detach-disk most likely wants the change to be permanent.

Actually I wonder what the expectation is.

The QEMU driver only implements a very limited form of the
virDomainAttachDevice call (merely allowing you to signal that the
CD-ROM has been replaced) and doesn't implement virDomainDetachDevice
at all, so there is no example to go on there.

Maybe better to document what the behaviour is supposed to be in
src/libvirt.c?  After all you can effect a permanent change to the
device configuration by using virDomainDefineXML.

Just my 0.02$

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v