[Libvir] proposal: remove contradictory indentation directive

Daniel P. Berrange berrange at redhat.com
Wed Apr 9 14:42:59 UTC 2008


On Wed, Apr 09, 2008 at 02:40:13PM +0100, Richard W.M. Jones wrote:
> On Wed, Apr 09, 2008 at 02:43:22PM +0200, Jim Meyering wrote:
> > Please don't add the "tab-width: 4" specifier.
> > Specifying a tab-width at all in a new file with "indent-tabs-mode: nil"
> > is a contradiction.  The latter says there should be no TABs, yet
> > the former says "when there are, give them width 4."  Coding style
> > guidelines are universal in their recommendations to stick with 8-byte
> > TAB stops, independent of whether you actually use TAB or spaces.
> 
> Agreed, good idea.

ACK.

Could we get a make syntax-check test to look for these bogus tabs too

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the libvir-list mailing list