[Libvir] proposal: remove contradictory indentation directive

Jim Meyering jim at meyering.net
Thu Apr 10 07:29:28 UTC 2008


Hi Mark,

Mark McLoughlin <markmc at redhat.com> wrote:
> On Wed, 2008-04-09 at 20:42 +0200, Jim Meyering wrote:
>> Any global space-changing delta like these is going to cause
>> trouble (conflicts) for people with pending changes and on branches.
>
> IMHO, the bigger issue with patches like this is that it makes digging
> into the history with "cvs annotate" a pain.

In that case, just use git.

[ sorry, I couldn't resist ;-)
  There is a git mirror of libvirt: git://et.redhat.com/libvirt ]

True, a global change like this does obscure the most basic annotate
output.  Though, as I said, what I'm doing isn't that big -- and nowhere
near as bad as filtering all of the code through indent.

You probably know, and this is what you mean by "pain", but you can
peel off the offending layer by specifying a revision (-r REV) or
date (-D date) option.

> But then, mixed tabs vs. spaces does annoy the crap out me too ...




More information about the libvir-list mailing list