[Libvir] PATCH: Use macros to remove duplicate test code

Richard W.M. Jones rjones at redhat.com
Fri Apr 18 08:33:58 UTC 2008


On Fri, Apr 18, 2008 at 01:32:49AM +0100, Daniel P. Berrange wrote:
> The test suite files contain alot of boilerplate duplicated code. With a
> few more macros I can significantly cut down the size of the test code.
> 
> I also change abs_top_srcdir to abs_srcdir, and automatically initialize
> it to 'getcwd' if the env variable is missing. This lets me run the test
> cases directly, rather than having to go via 'make check'.
> 
>  statstest.c    |  207 ++++++++++++++++++++++-------------------------------
>  test_conf.sh   |   16 +++-
>  xencapstest.c  |   10 --
>  xmconfigtest.c |  220 ++++++++++++---------------------------------------------
>  4 files changed, 149 insertions(+), 304 deletions(-)

+1

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v




More information about the libvir-list mailing list