[Libvir] PATCH: Support network interface model in Xen and QEMU driver
jim at meyering.net
Tue Apr 29 21:04:31 UTC 2008
"Daniel P. Berrange" <berrange at redhat.com> wrote:
> On Tue, Apr 29, 2008 at 06:20:01PM +0100, Daniel P. Berrange wrote:
>> This patch finishes off the work from Rich / Soren to support network
>> interface model in both Xen and QEMU drivers, and adds test cases for
>> the new syntax
> Here is a re-diff following Jim's xmlFree cleanups.
Looks fine to me.
> +/usr/bin/qemu -M pc -m 214 -smp 1 -nographic -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net nic,macaddr=00:11:22:33:44:55,vlan=0,model=virtio -net user,vlan=0 -serial none -parallel none -usb
It'd be nice to change the line above to e.g.,
qemu -M pc -m 214 -smp 1 -nographic -monitor pty \
-no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 \
-net nic,macaddr=00:11:22:33:44:55,vlan=0,model=virtio \
-net user,vlan=0 -serial none -parallel none -usb
When possible, I prefer not to hard-code program names like /usr/bin/qemu
in tests, because that lets the test work even when the tool in question
is installed somewhere else.
What if someone is using qemu they built themselves...
More information about the libvir-list