[Libvir] Re: Lxc conf patch

Daniel Veillard veillard at redhat.com
Tue Apr 1 13:01:08 UTC 2008


On Mon, Mar 31, 2008 at 03:24:22PM -0700, Dave Leskovec wrote:
> Meant to include this in the last reply - Here's a patch for the lxcFreeVMs() issue:
> 
> > 
> > This breaks doesn't it?  After calling lxcFreeVM(), curVm is no longer valid
> > since it was free()'d.  Need to pull out the next pointer before lxcFreeVM().

  yup, obviously access to freed memory, my bad ...

>      while (curVm) {
> -        lxcFreeVM(curVm);
>          nextVm = curVm->next;
> +        lxcFreeVM(curVm);
>          curVm = nextVm;

  Applied and commited, 

    thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/




More information about the libvir-list mailing list