[Libvir] proposal: remove contradictory indentation directive

Mark McLoughlin markmc at redhat.com
Thu Apr 10 08:14:01 UTC 2008

On Thu, 2008-04-10 at 09:29 +0200, Jim Meyering wrote:

> Mark McLoughlin <markmc at redhat.com> wrote:
> > On Wed, 2008-04-09 at 20:42 +0200, Jim Meyering wrote:
> >> Any global space-changing delta like these is going to cause
> >> trouble (conflicts) for people with pending changes and on branches.
> >
> > IMHO, the bigger issue with patches like this is that it makes digging
> > into the history with "cvs annotate" a pain.
> In that case, just use git.

Fully on-board with that, but it would still be an annoying artifact
when poking through history with git too. Less so, sure.

> True, a global change like this does obscure the most basic annotate
> output.  Though, as I said, what I'm doing isn't that big -- and nowhere
> near as bad as filtering all of the code through indent.

Yep, my point was not so much an objection to this particular change,
but that if one consistently dismisses the concern about reducing the
usefulness of a codebase's history and continue cleanups like this
ad-nauseum, then one ends up with near-useless history.

(But you must know this - core-utils has plenty of history :-)

> You probably know, and this is what you mean by "pain", but you can
> peel off the offending layer by specifying a revision (-r REV) or
> date (-D date) option.



More information about the libvir-list mailing list