[Libvir] [PATCH] avoid "make distcheck" failure
jim at meyering.net
Mon Apr 28 07:30:45 UTC 2008
Daniel Veillard <veillard at redhat.com> wrote:
> On Fri, Apr 25, 2008 at 07:27:00PM +0200, Jim Meyering wrote:
>> "make distcheck" was failing. This fixes it:
>> avoid "make distcheck" failure
>> * docs/Makefile.am (EXTRA_DIST): Replace wildcards html/*.html
>> and html/*.png the corresponding lists of file names.
> Hum, that's still changing a bit.
All the more reason *not* to use wildcards.
> For example we are likely to include the
> HTML for the ocaml and ruby bindings as part of the distribution, and parts
> of the graphic design, including images are gonna change.
> Anyway I'm still wondering why using wildcards would break in principle,
> any good reason to not use them ?
If fixing a failing "make distcheck" isn't a good enough reason,
take a look at the automake manual's section:
27.3 Why doesn't Automake support wildcards?
it gives several good reasons.
By the way, I made similar changes back in November.
More information about the libvir-list