[Libvir] [PATCH] avoid "make distcheck" failure
veillard at redhat.com
Mon Apr 28 08:19:22 UTC 2008
On Mon, Apr 28, 2008 at 09:30:45AM +0200, Jim Meyering wrote:
> Daniel Veillard <veillard at redhat.com> wrote:
> > On Fri, Apr 25, 2008 at 07:27:00PM +0200, Jim Meyering wrote:
> >> "make distcheck" was failing. This fixes it:
> >> avoid "make distcheck" failure
> >> * docs/Makefile.am (EXTRA_DIST): Replace wildcards html/*.html
> >> and html/*.png the corresponding lists of file names.
> > Hum, that's still changing a bit.
> All the more reason *not* to use wildcards.
I was just trying to carry the point that
"docs/ is a work in progress, will be fixed, sorry for the inconvenience"
> > For example we are likely to include the
> > HTML for the ocaml and ruby bindings as part of the distribution, and parts
> > of the graphic design, including images are gonna change.
> > Anyway I'm still wondering why using wildcards would break in principle,
> > any good reason to not use them ?
> If fixing a failing "make distcheck" isn't a good enough reason,
> take a look at the automake manual's section:
> 27.3 Why doesn't Automake support wildcards?
> it gives several good reasons.
Okay thanks, will fix. But cleaner fix is by fixing/reusing $(apihtml)
and $(apipng) that will be done as part of the docs/ fixup commit later.
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard at redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
More information about the libvir-list