[Libvir] [PATCH] avoid "make distcheck" failure

Jim Meyering jim at meyering.net
Mon Apr 28 08:44:16 UTC 2008

Daniel Veillard <veillard at redhat.com> wrote:
>   Okay thanks, will fix. But cleaner fix is by fixing/reusing $(apihtml)
> and $(apipng) that will be done as part of the docs/ fixup commit later.

As you say, it could be cleaner.
This patch relies on a gnu-make'ism, but there are already several
others in the vicinity:

	avoid "make distcheck" failure
	* docs/Makefile.am (EXTRA_DIST): Replace wildcards html/*.html
	and html/*.png the corresponding lists of file names.

diff --git a/docs/Makefile.am b/docs/Makefile.am
index feb72c1..d3f4c35 100644
--- a/docs/Makefile.am
+++ b/docs/Makefile.am
@@ -63,8 +63,10 @@ fig = \
 EXTRA_DIST=					\
   libvirt-api.xml libvirt-refs.xml apibuild.py	\
   site.xsl newapi.xsl news.xsl page.xsl	ChangeLog.xsl	\
-  $(dot_html) $(dot_html_in) $(gif) html/*.html html/*.png \
-  $(xml) $(rng) $(fig) $(png) \
+  $(dot_html) $(dot_html_in) $(gif)	\
+  $(apihtml:%=html/%)			\
+  $(apipng:%=html/%)			\
+  $(xml) $(rng) $(fig) $(png)		\
   virsh.pod ChangeLog.awk

 all: web $(top_builddir)/NEWS $(man_MANS)

More information about the libvir-list mailing list