[libvirt] PATCH: Fix const-ness for virRun/virExec

Jim Meyering jim at meyering.net
Fri Aug 8 11:47:29 UTC 2008


"Daniel P. Berrange" <berrange at redhat.com> wrote:
> The exec() family of UNIX functions have broken const-ness in the argv[]
> parameter. For inexplicable reasons, I followed this brokeness when
> originally doing the virRun/virExec functions. So every caller is either
> using wrong const-ness, or having to cast when calling them. This patch
> fixes the virRun/virExec API const-ness, so we only need apply a cast
> at the time we finally call exec()

+1 to massive cast removal + const-correctness fixes ;-)
Nice.

ACK




More information about the libvir-list mailing list