[libvirt] [PATCH] "static" ip address
Daniel P. Berrange
berrange at redhat.com
Fri Aug 15 09:43:15 UTC 2008
On Tue, Aug 12, 2008 at 05:24:01PM -0400, Daniel Veillard wrote:
> On Tue, Aug 12, 2008 at 03:39:28PM -0400, Daniel Veillard wrote:
> > On Tue, Aug 12, 2008 at 06:49:59PM +0200, Olivier Deckmyn wrote:
> > > On Tue, Aug 12, 2008 at 5:17 PM, Daniel Veillard <veillard at redhat.com>wrote:
> > > >
> > > > That said I'm working on a new version of the patch which would be adequate
> > [...]
> > > Once again, if I can do anything to help, I will.
> >
> > Then please try the following patch, tell me if it works for you, I didn't
> > really tried it yet and parallel testing would help.
> > The things to test are:
> > - no crash
> > - the network definition is correctly parsed
> > - virsh network define and dump still work
> > - and IP as provided by dnsmasq as suggested
> > in case of mismatches try to grab the full command line used by libvirtd
> > for dnsmasq and report it in parallel of the XML file used,
>
> New patch with just a pair of minor fixes which seems to work just fine for
> me. The syntax is nearly the old one, just use host instead of statichost:
>
> <ip address="192.168.122.1" netmask="255.255.255.0">
> <dhcp>
> <range start="192.168.122.4" end="192.168.122.254" />
> <host mac="00:16:3E:XX:XX:XX" host="XXX"
Seems a little odd to have 'host' as the element name and attribute
name at once. Perhaps the atribute should just be name='XXXX' ?
> @@ -1103,6 +1103,8 @@
> 2 + /* --listen-address 10.0.0.1 */
> 1 + /* --dhcp-leasefile=path */
> (2 * network->def->nranges) + /* --dhcp-range 10.0.0.2,10.0.0.254 */
> + /* --dhcp-host 01:23:45:67:89:0a,hostname,10.0.0.3 */
> + (2 * network->def->nhosts) +
Using the --dhcp-host option means we can't easily update on the fly, but
this patch doesn't support on the fly updates anyway, so not a huge deal.
In the future we can switch to --dhcp-host-file instead.
ACK to including this.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list