[libvirt] [PATCH] Don't list capabilities entries if emulators can't be accessed
Daniel P. Berrange
berrange at redhat.com
Wed Aug 20 17:16:07 UTC 2008
On Wed, Aug 20, 2008 at 12:51:05PM -0400, Cole Robinson wrote:
> The patch below fixes capabilities xml generation for
> the qemu driver if the emulators aren't found in the
> hardcoded paths. Current behavior will add a <guest>
> entry for the emulator even if it does not exist, patch
> fixes this to check that we actually have access.
>
> This brings up another issue, that hardcoded paths
> aren't exactly distro friendly. I'm not really familiar
> with what options we have to allow specifying these
> at build time (or something else). Anyone have an
> idea?
Ideally we'd just list the binary names, and search in $PATH for them.
Patches for this welcome...
> diff --git a/src/qemu_conf.c b/src/qemu_conf.c
> index dc9e42a..0328cc1 100644
> --- a/src/qemu_conf.c
> +++ b/src/qemu_conf.c
> @@ -230,6 +230,10 @@ qemudCapsInitGuest(virCapsPtr caps,
> virCapsGuestPtr guest;
> int i;
>
> + /* Check for existance of base emulator */
> + if (access(info->binary, X_OK) == -1)
> + return 0;
> +
This isn't right - this means that if KVM is installed, but QEMU is
not installed you won't get any capabilities.
Basically we need todo all the access() checks for QEMU, KVM, /dev/kvm
up-front. And then generated the capabilites if either QEMU or KVM is
available.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list