[libvirt] PATCH: Allow specific FDs to be kept open in virExec()
Daniel P. Berrange
berrange at redhat.com
Wed Aug 27 11:46:24 UTC 2008
On Wed, Aug 27, 2008 at 10:21:44AM +0100, Richard W.M. Jones wrote:
> On Tue, Aug 26, 2008 at 10:41:18AM +0100, Daniel P. Berrange wrote:
> > On Thu, Aug 21, 2008 at 02:58:30PM +0100, Daniel P. Berrange wrote:
> > > With my recent patches to virExec(), all FDs except stdin/out/err are closed
> > > before the child is exec'd to prevent accidental leaks. Of course I forgot
> > > the one key place where we need to propagate FDs... The TAP devices passed
> > > to QEMU.
> > >
> > > This patch adds a 'keepfd' parameter to virExec() which allows the caller
> > > to specify a bitset of file descriptors to keep open, and updates the
> > > callers to use this as required. The QEMU driver specifies any TAP fds
> > > and the LXC driver specifies its PTY this way removing a previous hack.
> > >
> > > QEMU networking works again with fix....
> >
> > Changed to use fd_set from sys/select
>
> Yup, +1.
Ok, committed this change - QEMU networking should work again now.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list