[libvirt] [PATCH]: Rework xenLinuxDomainDeviceID to support more devices
Chris Lalancette
clalance at redhat.com
Tue Aug 5 13:45:40 UTC 2008
Jim Meyering wrote:
> To retain the diagnostic Dan mentioned, you should be able to
> insert something like this just before the final "else":
>
> else if (disk_re_match("/dev/sd[a-z]([0-9])+$", mod_path, &part)) {
>
>> + else
>> + statsErrorFunc (conn, VIR_ERR_INVALID_ARG, __FUNCTION__,
>> + "unsupported path, use xvdN, hdN, or sdN", domid);
OK, another go, with all of Jim's concerns addressed. I did something like this
last point (thanks for the idea Jim), except that I didn't use regex's but basic
STRPREFIX() to get better error messages. Dan, is this better?
Chris Lalancette
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-stats-linux-expand-3.patch
Type: text/x-patch
Size: 13751 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080805/c1f9692b/attachment-0001.bin>
More information about the libvir-list
mailing list