[libvirt] [PATCH]: Fix "virsh attach-disk" and "virsh attach-interface"
Chris Lalancette
clalance at redhat.com
Tue Aug 5 16:43:57 UTC 2008
Daniel P. Berrange wrote:
>
> Ok, I've found the original xenDaemonAttachDevice() had this hack to make
> them consistent:
>
> if (!memcmp(sexpr, "(device ", 8)) {
> conf = sexpr + 8;
> *(conf + strlen(conf) -1) = 0; /* suppress final ) */
> }
> else
> conf = sexpr;
>
> Which is just gross.
Ah, ug, that is gross. Thanks for checking it out for me; I've committed this
patch now.
Chris Lalancette
More information about the libvir-list
mailing list