[libvirt] [PATCH] Fix serial console telnet protocol support

Guido Günther agx at sigxcpu.org
Thu Aug 14 08:21:25 UTC 2008


Hi Mark,
On Wed, Aug 13, 2008 at 06:44:28PM +0100, Mark McLoughlin wrote:
> With e.g.:
> 
>   <serial type='tcp'>
>     <source mode='bind' host='127.0.0.1' service='4444'/>
>     <protocol type='telnet'/>
>     <target port='0'/>
>   </serial>
> 
> You currently get:
> 
>   Unknown option: listen
>   qemu: could not open serial device 'telnet:127.0.0.1:4444,listen'
> 
> With the telnet protocol, qemu expects "server" as an option
> rather than "listen".
Not that I'm qualified to comment on this but a testcase in
tests/qemuxml2argv* would prevent breaking this in the future.
Cheers,
 -- Guido




More information about the libvir-list mailing list