[libvirt] [PATCH] storage pool discovery

[Daniel P. Berrange]

On Fri, Aug 22, 2008 at 11:06:38PM +0200, Jim Meyering wrote:
> David Lively <dlively at virtualiron.com> wrote:
> ...
> >> >  AM_CONDITIONAL([WITH_STORAGE_FS], [test "$with_storage_fs" = "yes"])
> >> > +if test "$with_storage_fs" = "yes"; then
> >> > +  AC_PATH_PROG([SHOWMOUNT], [showmount], [], [$PATH:/sbin:/usr/sbin])
> >> > +  AC_DEFINE_UNQUOTED([SHOWMOUNT], ["$SHOWMOUNT"],
> >> > +    [Location or name of the showmount program])
> >> > +fi
> >>
> >> Do we want to require the "showmount" package via the spec file?
> >
> > I was a little worried about this too.  It's probably better to handle
> > this more like "iscsiadmin"/--with-storage-iscsi: defaults to enabling
> > iscsi backend if and only if iscsiadmin is present.  Fails with
> > --with-storage-iscsi=yes explicitly specified and iscsiadmin not found.
> 
> Adding "Requires: showmount" and BuildRequires lines to
> libvirt.spec.in would be similar to the approach of requiring
> the iscsi-initiator-utils package (which contains iscsiadm):

Yes, basically the spec file should encode 'best practice' and as such
it is reasonable to add a 'Requires: showmount'.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|