[libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

[David Lutterkort]

On Tue, 2008-08-26 at 22:37 +0200, Raphaël Pinson wrote:
> Hi Daniel,
> 
> On Tue, Aug 26, 2008 at 10:05 PM, Daniel P. Berrange
> <berrange at redhat.com> wrote:
>         THis patch is intended to be committed to libvirt, so the
>         config file rules
>         are distributed alongside libvirt. I'm CC'ing augeas-devel for
>         feedback on
>         the lens itself.
> 
> Very nice idea. This might have to be thought about for the future
> since so far we're only adding lenses to the Augeas repository.

Long term, it was always my plan to have upstream ship their lenses - it
gets around a whole host of worries you need to have otherwise that the
lenses that come with Augeas really do match every version of upstream's
config file format.

>         ===================================================================
>         RCS file: qemud/libvirtd.aug
>         diff -N qemud/libvirtd.aug
>         --- /dev/null   1 Jan 1970 00:00:00 -0000
>         +++ qemud/libvirtd.aug  26 Aug 2008 20:03:48 -0000
>         @@ -0,0 +1,64 @@
>         +(* /etc/libvirt/libvirtd.conf *)
>         +
>         +module Libvirtd =
>         +   autoload xfm
>         +
>         +   let eol   = del /[ \t]*\n/ "\n"
> 
> This is also Util.eol

In general, I would agree that you should use definitions from Util
etc. 

But since we are not really that good yet at defining which of the
modules that come with Augeas are fixed (let alone having tests for all
that), and since these are all relatively small things, it's safer to
just leave the Libvirtd module standalone.
 
David