[libvirt] [PATCH] Fix vnc port determining for xend
Daniel P. Berrange
berrange at redhat.com
Thu Aug 28 20:52:21 UTC 2008
On Thu, Aug 28, 2008 at 04:48:06PM -0400, Cole Robinson wrote:
> Current libvirt checks xenstore for a xen guests
> fixed vnc port on xend > 3.0.3. At least on f8
> though, hvm guests don't store the vnc port in
> xenstore, it is stored in the sexpr.
>
> Patch fixes the logic to look in the sexpr if
> the xenstore lookup appears to fail. This fixes
> setting static vnc ports for f8 xen hvm guests.
Hmm, I thought this was already covered by our test suite. If it isn't
then we should add a test becuase the combinations of VNC / HVM / PV /
Xen version are a mine-field.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list