[libvirt] [PATCH] virConnectListAllDomains
Richard W.M. Jones
rjones at redhat.com
Fri Aug 29 13:30:55 UTC 2008
On Fri, Aug 29, 2008 at 02:26:47PM +0100, Daniel P. Berrange wrote:
> The compatability code requires that you get all virDomainInfo objects
> to filter by state, but a native implementation in the various drivers
> will not neccessarily require this to be done. I agree we should
> have the 'infos' parameter in the public API, it should be allowed
> to be NULL though.
OK, I'll change it so that infos can be NULL (but not domains).
Mainly this will involve changing the remote code.
> Fetching the info for QEMU guests is not entirely
> without costs of its own - read & parse several /proc/ files per
> VM, and filtering can be done without this, since QEMU tracks the state
> flag in libvirtd explicitly.
Yes, I missed the fact that qemuDomainGetInfo has to call out to get
process information. I thought it just got everything from the vm
structure.
> I'd like to see an implementation of this working against XenD before
> we commit this to API, since that's the driver which stands to gain
> the most from the performance improvements this API ought to allow.
OK, I don't have a way to test Xen right now. I was hoping I could
implement it for QEMU first.
builders--
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top
More information about the libvir-list
mailing list