[libvirt] Open monitor logs O_APPEND

Daniel P. Berrange berrange at redhat.com
Thu Dec 4 13:26:40 UTC 2008

On Thu, Dec 04, 2008 at 02:11:07PM +0100, Guido G?nther wrote:
> Hi,
> attached patch is from Debian Bug #507553:
> The logfile is opened with O_APPEND (to make logrotate work with
> copytruncate) and without O_TRUNC (to not lose log information e.g. with
> stop and start of a VM).
> Using collectd or munin to monitor VMs creates quiet a bit of qemu
> monitor output so the ability to use logrotate makes a lot of sense to
> me.

And is there a corresponding logrotate config file from Debian we
can use ?  If we're going to let log files append, then we need to
ship a logrotate config by default too.

ACK if we add a logrotate config too

|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

More information about the libvir-list mailing list