[libvirt] [PATCH] syntax-check: prohibit all new uses of gethostby* functions

R P Herrold herrold at owlriver.com
Thu Dec 11 14:28:12 UTC 2008


On Thu, 11 Dec 2008, Jim Meyering wrote:

> Good point.
> Yet another reason not to use gethostbyname.
> I think it's time to make the prohibition official.

I sure hope the Cygwin 1.7, which just released yesterday to 
formal beta trial, and brings in getaddrinfo() for my win 2000 
porting box, _works_ -- perhaps deprecate it for a while first 
(understanding it is stated as 'prohibit all new uses ...')?

> +# Not only do they fail to deal well with ipv6, but the gethostby*
> +# functions are also not thread-safe.

I think you mean to say here that the implementation you are 
encountering is not thread safe

> # Avoid useless parentheses like those in this example:
> # #if defined (SYMBOL) || defined (SYM2)
> sc_useless_cpp_parens:

I infer you can divine the future as to how the g++ 4.7.x 
implementers will decide parenthesizing will be first warned, 
and then error-ed ;)

-- Russ herrold




More information about the libvir-list mailing list