[libvirt] [PATCH] fix size parameter in calls to numa_node_to_cpus

[Daniel P. Berrange]

On Thu, Dec 11, 2008 at 03:07:11PM -0500, Dave Allan wrote:
> Daniel P. Berrange wrote:
> >On Thu, Dec 11, 2008 at 01:56:47PM -0500, Dave Allan wrote:
> >>I was getting the error:
> >>
> >>map size mismatch; abort
> >>
> >>when running the daemon-conf tests.
> >>
> >>I traced it to two places in which we were passing a parameter as a 
> >>number of bits to numa_node_to_cpus which expects a number of bytes (see 
> >>numa_node_to_cpus_compat in numa.h in the numactl source).
> >
> >I'm still very puzzelled by this. What OS and architecture are you
> >running on ?
> >
> >I'm using Fedora 10, x86_64 and don't see any messages with current
> >CVS and it returns NUMA info correctlys (as per virsh capabilities)
> >
> >Applying your patch and it still works correctly which is good, so
> >ACK to applying it from that point of view. I'd still like to
> >understand why I'm not seeing the error message, but you are...
> >
> >Daniel
> 
> I'm puzzled by why I'm the only one seeing it as well.  One difference 
> may be that I seem to have compiled --with-uml.  I'm not sure if that's 
> the way most people are doing things; it's just what I get from 
> autobuild.sh on my box.

UML actually defaults to on, so I have that too. In fact all drivers now
default to on, provided their compile pre-requisites exist.

Are you x86_64 too ?  Are you on an actual NUMA enabled machine ?
My machines are NUMA enabled.

> I'm still tracking down an unresolved issue on my setup during the 
> daemon-conf scripts, which is that libvirtd is getting farther into 
> running during the corrupt configuration tests than Jim thinks it 
> should.  I'll take a look to see if that is the reason for this behavior 
> as well.


FYI, I know there is at least 2 crash conditions in the daemon currently
due to my threading changes. I've got patches almost ready for those...

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|