[libvirt] [PATCH 1/5] write pid file into stateDir

Guido Günther agx at sigxcpu.org
Mon Dec 15 18:40:05 UTC 2008


On Mon, Dec 15, 2008 at 11:15:53AM +0000, Daniel P. Berrange wrote:
> On Fri, Dec 12, 2008 at 07:26:06PM +0100, Guido G?nther wrote:
> > @@ -870,6 +874,9 @@ int qemudBuildCommandLine(virConnectPtr conn,
> >      ADD_ARG_LIT("-monitor");
> >      ADD_ARG_LIT("pty");
> >  
> > +    ADD_ARG_LIT("-pidfile");
> > +    ADD_ARG(pidfile);
> > +
> 
> Not all versions of QEMU support the -pidfile argument. We'll have to add 
> another probe to qemudExtractVersionInfo() method as we do for -drive, 
> -uuid, etc.
I skipped this since -pidfile got introduced 2004 already with:

svn://svn.savannah.nongnu.org/qemu/trunk@1166

Do we really support that old qemu?
 -- Guido




More information about the libvir-list mailing list