[libvirt] [PATCH] Unify pool-create-as and pool-define-as xml building

Cole Robinson crobinso at redhat.com
Wed Dec 17 18:24:41 UTC 2008

The attached patch unifies the xml building and command line option
registering for the virsh pool-*-as commands, fixing a few bugs in the

- pool-define-as was creating <host> without a name attribute
  (rhbz 476708)
- pool-create-as wasn't adding a closing tag to its <host> block
- pool-create-as didn't have the source-name option

All seem like a good justification for not duplicating the logic. The
patch ends up looking a bit bizarre, but it's mostly just moving the xml
building from create-as into a separate function buildPoolXML, and then
wiring it up.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-virsh-pool-define-as.patch
Type: text/x-patch
Size: 8292 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20081217/44c42cbe/attachment-0001.bin>

More information about the libvir-list mailing list