[libvirt] [PATCH] don't assume builddir == srcdir

Guido Günther agx at sigxcpu.org
Thu Dec 18 08:29:38 UTC 2008

On Wed, Dec 17, 2008 at 03:31:45PM +0100, Jim Meyering wrote:
> Guido Günther <agx at sigxcpu.org> wrote:
> > Makefile.maint assumes this in some places. This doesn't make the world
> > perfect but maybe a bit better?
> Um, not really, since a pathological $(abs_srcdir) may contain "; rm -rf /;"
> Best to avoid it and use $(srcdir) instead.

> Were you able to construct a situation in which this change helped?
Yes. Running:
	make -f ../GNUmakefile <target>
starts working.

> I wonder, since in a non-srcdir builds,
> GNUmakefile and Makefile.maint don't exist, so it should be impossible
> to run their rules without either copying them into the build directory
> or using make's -f option.
> [copying the files into place, to test this ...]
> It looks like if you use VC_LIST's -C option,
> then that invalidates the exempted names in the .x-sc* files.
But that's the only problem left to fix to make "make distcheck" work
with $srcdir != builddir. Before that it wouldn't even run the tests.
Fixing up the pattern matching for the paths in the .x-sc* files still
on my todo list.
 -- Guido

More information about the libvir-list mailing list