[libvirt] PATCH: 2/28: Kill off macros in test driver
Daniel Veillard
veillard at redhat.com
Mon Dec 1 16:48:33 UTC 2008
On Sun, Nov 30, 2008 at 11:20:28PM +0000, Daniel P. Berrange wrote:
>
> The test driver has alot of convenience macros for for fetching the private
> internal object impls from the public API parameters. Unfortunately these
> rather obscure/hide code flow & variable accesses in the test driver, making
> it hard to determine whether a method is thread safe. So this patch removes
> all the macros, bringing this driver inline with the style of the other
> drivers
the alternative viewpoint is if such macros can't be generalized,
but with the goal of uniformizing code for locking, yes this makes sense.
> test.c | 899 ++++++++++++++++++++++++++++++++++++++++++++++++-----------------
that's a big patch but everything is systematic. Didn't spot anything
+1
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list