[libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)
Itamar Heim
iheim at redhat.com
Wed Dec 10 12:49:32 UTC 2008
> -----Original Message-----
> From: Daniel P. Berrange [mailto:berrange at redhat.com]
> In this bit of the code:
>
> diff --git a/src/domain_conf.h b/src/domain_conf.h
> index 51cf6d5..436d0b1 100644
> --- a/src/domain_conf.h
> +++ b/src/domain_conf.h
> @@ -268,6 +268,7 @@ struct _virDomainGraphicsDef {
> struct {
> char *display;
> char *xauth;
> + char *fullscreen;
> } sdl;
> } data;
> };
>
>
>
> You shouldn't use a char * for fullscreen. This is a boolean flag, so
> it should just be an bitfield 'int fullscreen: 1'. This avoids the
> issue DV pointed out of unexpected values in the XML.
[IH] this is used to get the string from the xml, to compare it to the
string 'true'.
Will the xml parsing infrastructure automatically convert true/false to
int and handle parsing errors or I need to write that code in another
place?
More information about the libvir-list
mailing list