[Libvir] [PATCH] Avoid new "make syntax-check" failures.
Jim Meyering
jim at meyering.net
Mon Feb 25 10:11:35 UTC 2008
Daniel Veillard <veillard at redhat.com> wrote:
> On Fri, Feb 22, 2008 at 09:33:26PM +0100, Jim Meyering wrote:
>> With recent changes, I introduced some new "make syntax-check"
>> failures. Also, there were two remaining invalid uses of write(2).
>> This fixes all that.
>>
>> Avoid new "make syntax-check" failures.
>> * .x-sc_avoid_write: Exempt src/util-lib.c, too.
>> * Makefile.maint (sc_unmarked_diagnostics): Filter out false positives.
>> * src/storage_backend_fs.c (virStorageBackendFileSystemVolCreate):
>> Use safewrite, not write.
>> * src/storage_backend_logical.c (virStorageBackendLogicalBuildPool):
>> Likewise.
>
> makes sense to me, except the Makefile.maint regexps i can't decypher, +1
Thanks for the review.
Let me know if you'd like more commentary.
I've considered using perl for such things; then you
can create multi-line regexps with comments etc, but it's
not really feasible (quoting issues) to do that directly in a Makefile.
I committed it.
More information about the libvir-list
mailing list