[Libvir] [PATCH] (for discussion) DHCP host mappings using 3 arrays API

Jim Meyering jim at meyering.net
Tue Feb 26 10:43:59 UTC 2008


"Richard W.M. Jones" <rjones at redhat.com> wrote:
> This patch is an evolution of the previous patch for implementing DHCP
...
> +    if (maxmappings == 0) return 0;
...
> +                if (col == 0) hwaddr = token;
...
> +                if (!(*hwaddrs)[lines]) goto mem_error;

Hi Rich,

Is there a libvirt style convention that says whether
a one-line if-block is written all on one line?
I find it slightly easier to spot the conditional at a glance
when the statement is on a separate line, but can certainly adapt
to a different style.




More information about the libvir-list mailing list