[Libvir] [PATCH] #include "config.h" needed

Richard W.M. Jones rjones at redhat.com
Thu Jan 3 15:13:37 UTC 2008


There is one file missing:

   #include "config.h"

which ought to be included at the beginning of every C file.  If 
missing, it causes problems on Windows -- in particular the C99 keyword 
'restrict' won't be recognised and that causes compile errors all over 
the place.

I've also changed a few <config.h> --> "config.h", which I think is more 
correct because config.h is a local file and should never come from the 
system include files (CC'd to Jim Meyering -- is this right in your 
opinion?)

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: config.h.patch
Type: text/x-patch
Size: 2122 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080103/9cd347be/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080103/9cd347be/attachment-0003.bin>


More information about the libvir-list mailing list