[Libvir] PATCH: BZ 426425: Fix truncated reading of config files

Richard W.M. Jones rjones at redhat.com
Fri Jan 4 09:55:47 UTC 2008

Daniel P. Berrange wrote:
> The virConfReadFile  API  has a fixed 4096 byte buffer it reads the config
> file into, regardless of the config file size and silently drops any data
> exceeding this. 

Ah, the joys of C ...

> +    if ((ret = fread(*buf, st.st_size, 1, fh)) != 1) {
> +        free(buf);
> +        buf = NULL;

I wonder if you meant to write *buf = NULL here?

Rest of the patch +1


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080104/8b8b0873/attachment-0001.bin>

More information about the libvir-list mailing list