[Libvir] [patch 6/9] Move iptablesSpawn()

Mark McLoughlin markmc at redhat.com
Mon Jan 7 10:02:20 UTC 2008

On Sat, 2008-01-05 at 00:11 +0000, Daniel P. Berrange wrote:
> On Fri, Jan 04, 2008 at 03:57:31PM +0000, Mark McLoughlin wrote:
> > The next patch requires iptablesSpawn() higher up in
> > the file. This patch just moves the code around; there
> > is no functional change.
> The util.c file has a virExec function, although its a little more
> cumbersome to use than iptablesSpawn. So for the storage APIs I've
> got a new virRun() function in util.c which is very similar to your
> iptablesSpawn code. How about we just make iptables use the virRun
> method in the attached patch ?

	Okay, the only thing lost with this is that when using WITH_ERRORS,
iptables error spew would go to libvirtd stderr, now it goes
to /dev/null. No big deal.

	(I'll fold the attached patch into the "use utils.[ch]" patch)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-iptables-use-vir-run.patch
Type: text/x-patch
Size: 3452 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080107/a1103ef9/attachment-0001.bin>

More information about the libvir-list mailing list