[Libvir] [PATCH] change a Disk/Nic of inactive domain

Richard W.M. Jones rjones at redhat.com
Mon Jan 14 12:25:44 UTC 2008

S.Sakamoto wrote:
>> These struct definitions *intentionally* private.
> Oops, I did not notice it...
> I revised a patch not to access the struct data directly.

In principle this patch looks good.  If no one else objects, I'll commit 
this, with a few of my own fixes (below).


+        (obj->stringval) && !strcmp((char*)obj->stringval, "hvm"))

I'm going to use STREQ macro here instead of !strcmp.

+    if (ctxt)
+        xmlXPathFreeContext(ctxt);

There are a few potential double-frees on the cleanup path.  Need to set 
ctxt back to NULL after freeing it.

Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080114/067013e0/attachment-0001.bin>

More information about the libvir-list mailing list