[Libvir] [PATCH] Clean up the global name space.

Richard W.M. Jones rjones at redhat.com
Mon Jan 14 12:33:56 UTC 2008

Jim Meyering wrote:
> After mentioning "avoid global variables" as a potential
> addition to HACKING, I did some quick tests and spotted
> a few that are easy to eliminate.  This is useful even
> if we don't end up automating the check:
> 	Clean up the global name space.
> 	* src/qemu_conf.c: Add "static" and "const" attributes to some globals.
> 	* src/qemu_conf.h: Update a declaration.
> 	* src/qemu_driver.c (qemud_driver): Declare static.


These structures were originally shared between files, but lots of code 
refactoring since seems to make that obsolete.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080114/8d9ba0c0/attachment-0001.bin>

More information about the libvir-list mailing list